Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add coderd_organization_sync_settings resource #173

Merged
merged 14 commits into from
Feb 20, 2025
Merged

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Jan 31, 2025

Part of #150

Technically, this is complete by itself, as you can entirely configure organization sync this way, but this PR does not include the proposed "partial" API that we would still like to implement.

Example:

resource "coderd_organization_sync_settings" "test" {
	field          = "wibble"
	assign_default = false

	mapping = {
		wobble = [
			"bf37c14a-cd36-4bf0-8ffb-e70d6ef8c518",
		]
	}
}

@aslilac aslilac changed the title wip: coderd_organization_sync_settings resource feat: add coderd_organization_sync_settings resource Feb 20, 2025
Copy link
Member

@ethanndickson ethanndickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have so much of an understanding of IdP sync settings, but this mostly lgtm!
My only real comments are on how this resource handles getting imported.

@aslilac
Copy link
Member Author

aslilac commented Feb 20, 2025

I'm realizing that you don't actually have to implement import, and I think skipping it is better than a janky import that's weird and has potential issues/adds complexity.

There can only ever be one of this type of resource (which does break the Terraform model a bit, but is also what our customers want) so importing isn't actually very helpful here.

@aslilac aslilac merged commit 5fa9117 into main Feb 20, 2025
13 checks passed
@aslilac aslilac deleted the lilac/org-sync branch February 20, 2025 18:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants