-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: add coderd_organization_sync_settings
resource
#173
Conversation
coderd_organization_sync_settings
resourcecoderd_organization_sync_settings
resource
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only have so much of an understanding of IdP sync settings, but this mostly lgtm!
My only real comments are on how this resource handles getting imported.
I'm realizing that you don't actually have to implement import, and I think skipping it is better than a janky import that's weird and has potential issues/adds complexity. There can only ever be one of this type of resource (which does break the Terraform model a bit, but is also what our customers want) so importing isn't actually very helpful here. |
Part of #150
Technically, this is complete by itself, as you can entirely configure organization sync this way, but this PR does not include the proposed "partial" API that we would still like to implement.
Example: