Refresh workspaces when logging in and out #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise you get some confusing ECONNREFUSED errors in the logs.
code-asher
force-pushed
the
asher/refresh-workspaces
branch
from
952d3f5 to
4b80455
Compare
Currently the refresh button does exactly nothing. This will also let us load new workspaces in other cases, like when logging in or out.
code-asher
force-pushed
the
asher/refresh-workspaces
branch
from
4b80455 to
dd9d42f
Compare
code-asher
force-pushed
the
asher/refresh-workspaces
branch
3 times, most recently
from
176ef81 to
4ab3038
Compare
I moved the async call out to make it easier to avoid adding new watches if we log out while fetching workspaces.
code-asher
force-pushed
the
asher/refresh-workspaces
branch
from
4ab3038 to
cb95d39
Compare
kylecarbs
approved these changes
Aug 18, 2023
|
Nice!!!! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #112