-
Notifications
You must be signed in to change notification settings - Fork 24
feat: show agent metadata #92
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Wow loved it. Awesome addition. |
@rodrimaia the agent name is already shown in the workspace title, so I'm not sure we should add another item to the bottom bar all the time. e.g. if I have no metadata right now, what shows up? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me. My only considerations are:
- What happens if it is empty or the agent is not connected
- If there is no way to align the value text to the right, I'm ok with this version
|
@rodrimaia could you update the screenshot with the new display? |
|
@rodrimaia thoughts on putting metadata in the Coder sidebar instead? |
The reason is that it's kinda odd for dynamic data to go in the tooltip, and in the UI we have a "Copy" button, which might be useful in the extension too. |
@kylecarbs I am experimenting with showing the metadata on the sidebar. I will post it here when I reach a working version. |
the UI alignment is not working as it is supposed to, I guess something related to the vscode tooltip internals (because the string itself is correct). I can investigate this later, but I don't think that is a blocker.Closes #71