Skip to content

Use local filesystem instead of browser storage #26

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2021
Merged

Use local filesystem instead of browser storage #26

merged 1 commit into from
Dec 14, 2021

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented Dec 13, 2021 •
edited
Loading

Maybe this also does something for coder/code-server#4263

@code-asher code-asher requested a review from jsjoeio December 13, 2021 22:06
@code-asher
Use local filesystem instead of browser storage
d6c14d7 
This is another patch we lost although I have implemented it in a
slightly different way (it used to use the payload but I changed it to
match the method we currently use to pass data to the frontend although
maybe we should have used the payload for all that).

coder/code-server#4609
jsjoeio
jsjoeio approved these changes Dec 14, 2021
View reviewed changes
Copy link

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm always amazed at how small (but mighty) your PRs are. I guess since you've patched this in the past, it was straightforward. Still impressive!

@code-asher code-asher merged commit 41de341 into coder:main Dec 14, 2021
@code-asher code-asher deleted the local-filesystem branch December 14, 2021 17:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jsjoeio jsjoeio jsjoeio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@code-asher @jsjoeio