Fixed vendor:publish tag name

[askdkc]

When you use custom view namespace in spatie laravel-package-tools, you need to use your custom namespace for your published view's tag name. This PR is fix for that.

[ousid]

Hey, @askdkc

Is publishing with csv-views tag doesn't work?

[askdkc]

@ousid

I fixed laravel-package-tools bug with this PR. Which will change tag name if you use custom view namespace. Your code is using custom namespace thus you need to fix your tag name.

[askdkc]

@ousid just try your code by yourself and check out what outputs your vendor:publish makes. You should see it by yourself.

[ousid]

@askdkc, The published files are works just fine.

This package uses ^1.9.2, and your PR was merged for ^1.13.6. So, I don't think it will affect this package for now, Or I am missing something?

Edit: Sorry, I didn't see your comment on the #8, and I didn't test laravel-csv-views tag also. Yeah, you're right.

Thanks for the PR, and Resolving the both issues!

[askdkc]

@ousid

just try installing your package to newly created laravel project like this.

laravel new laravelcsv
(or  composer create-project laravel/laravel --prefer-dist laravelcsv)

cd laravecsv
composer require coderflex/laravel-csv


php artisan vendor:publish --tag="csv-views"

And you get this:

    INFO  No publishable resources for tag [csv-views].  

You see? No publishable resources for tag [csv-views].

[ousid]

@ousid

just try installing your package to newly created laravel project like this.

laravel new laravelcsv
cd laravecsv
composer require coderflex/laravel-csv

php artisan vendor:publish --tag="csv-views"

And you get this:

    INFO  No publishable resources for tag [csv-views].  

You see? No publishable resources for tag [csv-views].

Yep, I realized it just after I see the comment in the mentioned issue above.

[askdkc]

@ousid
Thank you for your understanding👍

But hopefully you should test it before asking questions. I kinda hate repeating myself.
Trying to help here😅

[ousid]

@askdkc

I tested all the published files except the views 😅

Thanks again for your PR's and enhancing this package for the better

[askdkc]

@ousid
This bug is tough to fix to begin with, I guess. Coz there is nothing wrong with your package but rather, other package is causing this issue. Anyway, it's nice to see it gets resolved.

Have a great day.