Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Updates to make testing happy #657

Merged
merged 6 commits into from
Sep 15, 2024
Merged

Updates to make testing happy #657

merged 6 commits into from
Sep 15, 2024

Conversation

Apollon77
Copy link
Collaborator

No description provided.

@Apollon77 Apollon77 mentioned this pull request Aug 15, 2024
@coveralls
Copy link

coveralls commented Aug 15, 2024

Coverage Status

coverage: 58.841% (-0.03%) from 58.866%
when pulling b0e7790 on Apollon77:35upd
into 59883ed on codetheweb:master.

@Apollon77 Apollon77 requested a review from codetheweb August 15, 2024 22:06
Copy link
Contributor

@nospam2k nospam2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Apollon77
Copy link
Collaborator Author

@codetheweb I added also one unrelated PR to to because I noticed some weird timeout stuff while looking at another PR ... And I also might want to cleanup some dangling promises here and there .. They all can lead to uncatcheable errors - but that comes after my vacation :-)

@Apollon77
Copy link
Collaborator Author

@codetheweb Can you give me rights to merge please or merge this one and the second one?

@Apollon77 Apollon77 merged commit 8fc57a0 into codetheweb:master Sep 15, 2024
15 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants