Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Bug] [Critical] 2.20.1 BlockTune and Default tunes disappear. #1640

Closed
kaaaaaaaaaaai opened this issue Apr 10, 2021 · 1 comment · Fixed by #1649
Closed

[Bug] [Critical] 2.20.1 BlockTune and Default tunes disappear. #1640

kaaaaaaaaaaai opened this issue Apr 10, 2021 · 1 comment · Fixed by #1649
Assignees
Labels

Comments

@kaaaaaaaaaaai
Copy link
Contributor

kaaaaaaaaaaai commented Apr 10, 2021

@gohabereg

After I updated the version from 2.20.0 to 2.20.1, Tune disappeared.
Is it a bug?
It seems to happen only when using the BlockTuneAPI.

https://github.com/kaaaaaaaaaaai/editorjs-alignment-blocktune

ver2.20.0

  <script src="https://cdn.jsdelivr.net/npm/@editorjs/editorjs@2.20.0/dist/editor.min.js"></script>

image

ver2.20.1

  <script src="https://cdn.jsdelivr.net/npm/@editorjs/editorjs@2.20.1/dist/editor.min.js"></script>

image

@kaaaaaaaaaaai
Copy link
Contributor Author

editor-js/link#48 same problems,
@talyguryn @neSpecc

image
image

 <script src="https://cdn.jsdelivr.net/npm/@editorjs/editorjs@2.20.1/dist/editor.min.js"></script>
  <script src="https://cdn.jsdelivr.net/npm/@editorjs/header@latest"></script>

  <!-- Initialization -->
  <script>
    const saveButton = document.getElementById('saveButton');
    var editor = new EditorJS({
      holder: 'editorjs',
      tools: {
        header:Header
      },
      onReady: function(){
        saveButton.click();
      },
      onChange: function() {
        console.log('something changed');
      },
    });
    saveButton.addEventListener('click', function () {
      editor.save().then((savedData) => {
        cPreview.show(savedData, document.getElementById("output"));
      });
    });
  </script>

@kaaaaaaaaaaai kaaaaaaaaaaai changed the title [Bug] 2.20.1 BlockTune and Default tunes disappear. Is it a bug? [Bug] [Critical] 2.20.1 BlockTune and Default tunes disappear. Apr 11, 2021
@gohabereg gohabereg self-assigned this Apr 11, 2021
gohabereg added a commit that referenced this issue Apr 11, 2021
gohabereg added a commit that referenced this issue Apr 14, 2021
* Fix #1640

* Update changelog

* Fix typo
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants