BugFix 1302 undefined name #1336
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit def0f08.
gohabereg
requested changes
Sep 30, 2020
src/components/modules/ui.ts
Outdated
| * currentBlock !=undefined | ||
| * Ignore when KeyDown Element is null | ||
| */ | ||
| const keyDownOnEditor = (event.target as HTMLElement).closest(`.${this.CSS.editorWrapper}`) || currentBlock != undefined; |
There was a problem hiding this comment.
Suggested change
| const keyDownOnEditor = (event.target as HTMLElement).closest(`.${this.CSS.editorWrapper}`) || currentBlock != undefined; | |
| const keyDownOnEditor = (event.target as HTMLElement).closest(`.${this.CSS.editorWrapper}`) || currentBlock !== undefined; |
neSpecc
requested changes
Sep 30, 2020
src/components/modules/ui.ts
Outdated
| * currentBlock !=undefined | ||
| * Ignore when KeyDown Element is null | ||
| */ | ||
| const keyDownOnEditor = (event.target as HTMLElement).closest(`.${this.CSS.editorWrapper}`) || currentBlock != undefined; |
There was a problem hiding this comment.
let's move the currentBlock !== undefined statement to the separate variable and describe this case (why it is counts as keydown on editor)
talyguryn
approved these changes
Oct 1, 2020
gohabereg
requested changes
Oct 5, 2020
| /** | ||
| * Transfer event when currentBlock defined and keyDownOnEditor is null | ||
| */ | ||
| if(currentBlock!== undefined && keyDownOnEditor===null){ |
There was a problem hiding this comment.
Suggested change
| if(currentBlock!== undefined && keyDownOnEditor===null){ | |
| if(currentBlock !== undefined && keyDownOnEditor === null){ |
| */ | ||
| if(currentBlock!== undefined && keyDownOnEditor===null){ | ||
| this.Editor.BlockEvents.keydown(event); | ||
| return; |
There was a problem hiding this comment.
Suggested change
| return; | |
| return; |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1302
Remaining: