Change shortcut listener binding #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hata6502
force-pushed
the
bugfix/change-shortcut-listener-binding
branch
from
0df3efb to
6d273d0
Compare
hata6502
requested review from
gohabereg,
khaydarov and
neSpecc
as code owners
hata6502
force-pushed
the
bugfix/change-shortcut-listener-binding
branch
from
6d273d0 to
d056a0e
Compare
khaydarov
approved these changes
Nov 21, 2020
|
We registered shortcuts on document consciously because of CMD+X according to this issue, but now we use native 'cut' event |
|
@khaydarov @Thank.you for reviewing. |
gohabereg
approved these changes
Nov 21, 2020
hata6502
force-pushed
the
bugfix/change-shortcut-listener-binding
branch
from
7144bd7 to
1bc1094
Compare
hata6502
force-pushed
the
bugfix/change-shortcut-listener-binding
branch
from
1bc1094 to
9616739
Compare
neSpecc
approved these changes
Nov 21, 2020
neSpecc
added a commit
that referenced
this pull request
Dec 8, 2020
* Change shortcut listener binding * Update CHANGELOG.md Co-authored-by: Peter Savchenko <specc.dev@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1391