Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(notification-rule): implement new notification pattern #448

Merged
merged 21 commits into from
Feb 2, 2025

Conversation

e11sy
Copy link
Contributor

@e11sy e11sy commented Jan 8, 2025

This PR is a part of work on new notification model
check related PRs in:

Changes

  • now API does not support ReceiveTypes.ALL , we have ReceiveTypes.SEEN_MORE instead
  • add threshold and thresholdPeriod properties to notificationRule entities
  • update mutations and schemas for new notifications pattern

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.62%. Comparing base (424edb0) to head (f1ea748).
Report is 17 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #448   +/-   ##
=======================================
  Coverage   54.62%   54.62%           
=======================================
  Files           9        9           
  Lines         119      119           
  Branches       10       10           
=======================================
  Hits           65       65           
  Misses         50       50           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@e11sy e11sy changed the title types(notification-rule): respect new notification model feat(notification-rule): implement new notification pattern Feb 1, 2025
@e11sy e11sy marked this pull request as ready for review February 1, 2025 18:56
@e11sy e11sy merged commit fe24cb3 into master Feb 2, 2025
5 of 6 checks passed
@e11sy e11sy deleted the update-notification-rule-types branch February 2, 2025 20:21
@neSpecc neSpecc mentioned this pull request Feb 3, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants