Skip to content

text margins for RTL text in transaction details screen #791

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jun 12, 2018

Conversation

pnemonic78
Copy link
Contributor

fixes #790

Copy link
Owner

@codinguser codinguser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be layout_marginStart instead of layout_marginEnd?
I think Android knows that for RTL locales, marginStart is on the right, and for LTR locales it is on the left.

Maybe we should also add the android:supportsRTL attribute to the application manifest. And then check that it does the right thing for all views.
https://developer.android.com/about/versions/android-4.2#RTL
What do you think?

@pnemonic78
Copy link
Contributor Author

Don't confuse RTL content with RTL layouts.
android:layout_marginStart is "left" to LTR layouts, but "right" for RTL layouts. For example, the "x" button appears on top-left in LTR layout, but will be in top-right in RTL layout => title margin should be on left => margin should be "end".

Cannot just add android:supportsRTL without checking that all the screens are still OK.

@codinguser codinguser merged commit a35d233 into codinguser:develop Jun 12, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants