Fix slow CSV exports #845
Merged
Fix slow CSV exports #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For each split in every exported transaction, the code fetched the whole Account instance, including all its transactions with all their splits. This resulted in hundreds of thousands of requests with a medium-sized ledger. There was a cache mechanism, but it was local to one single transaction, thus essentially useless. Now, each split generates two requests, to get the account's name and full name. A better cache mechanism would speed this up further.
Caching allows us to decrease the number of database requests. We did two requests per exported split before this commit; now we only do two requests per unique account in all splits.
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSV exporting was taking tens of minutes on my phone, for only around 120 exported transactions, and a database containing 2 years worth of personal finances.
This PR fixes it. Technical details are in commit messages, but basically: the code fetched all transactions from one account for every single exported split. That meant easily tens of thousands or even hundreds of thousands requests for one export.