#71 Null value matching problem

[partikus]

@norzechowicz code review please

[partikus]

@norzechowicz if we want to fix nullable value then we cannot rely on getValue() !== null,
In order to keep backward compatibility and support for PropertyAccessor v2.3 I'd like to suggest write custom property accessor with isReadable method or since version 2.0 we can switch PA to newer version >=2.5

What do you think? Have you got any advices?

[norberttech]

why u enabled that option?

[partikus]

if exceptionOnInvalidIndex is disabled then isReadable method returns true for unexisting properties of array, but if this option is enabled isReadable method catches all exceptions (eg InvalidIndex) and returns false. That's why I enabled exceptions.
Unfortunately this method was added in 2.5

e.g.
https://github.com/symfony/property-access/blob/2.5/PropertyAccessor.php#L134

[norberttech]

Well in that case I guess you can just update dependency to 2.5^ in this PR (it will be tagged as 2.0 anyway). Recommended solution for versions 1.0 and 1.1 will be update to 2.0 for now, and maybe somebody will find a way to fix it also there.

[partikus]

I've prepared compatible version with 2.3^

@norzechowicz cr ping

[norberttech]

wow cool! Could you please squash those commits into one? I would need to cherry pick them to version 1.1 and 1.0 also probably.

[partikus]

@norzechowicz done

[norberttech]

@partikus thanks! I will merge it later, after that I will merge OR operator and then I will release rc2. 👍

[partikus]

@norzechowicz good news, thanks!