Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove an optional dependency on symfony/intl #6

Merged
merged 1 commit into from
Jan 20, 2016
Merged

Remove an optional dependency on symfony/intl #6

merged 1 commit into from
Jan 20, 2016

Conversation

jakzal
Copy link
Contributor

@jakzal jakzal commented Jan 20, 2016

Not sure where's this used in the library, but the current requirement prevents composer from installing it with Symfony 3.

@jakzal
Copy link
Contributor Author

jakzal commented Jan 20, 2016

Fine, I guess you wanted to support those people without the intl extension installed. It doesn't need to be a hard dependency.

Btw, specs won't pass with symfony/intl as it only support English locale.

@norberttech
Copy link
Member

well maybe just remove it

@jakzal jakzal changed the title Allow symfony/intl v3.0 Remove an optional dependency on symfony/intl Jan 20, 2016
@jakzal
Copy link
Contributor Author

jakzal commented Jan 20, 2016

I think that's the best thing to do. If someone wants to substitute the intl extension with symfony/intl, they can always install it themselves.

PR updated.

norberttech pushed a commit that referenced this pull request Jan 20, 2016
Remove an optional dependency on symfony/intl
@norberttech norberttech merged commit 4c1d7e2 into coduo:master Jan 20, 2016
@norberttech
Copy link
Member

thanks ;*

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants