Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

make com.cognitect/http-client source available #23

Closed
mpenet opened this issue Dec 12, 2018 · 6 comments
Closed

make com.cognitect/http-client source available #23

mpenet opened this issue Dec 12, 2018 · 6 comments

Comments

@mpenet
Copy link

mpenet commented Dec 12, 2018

Hi,

First of all: thanks for the project.

One of the deps listed is available on maven and seems to be Apache 2 licensed but the sources are not available anywhere as far as I can see. Would it be possible to publish these?

https://search.maven.org/artifact/com.cognitect/http-client/0.1.87/jar

@dchelimsky
Copy link
Contributor

The sources are in the released jar: http://central.maven.org/maven2/com/cognitect/http-client/0.1.87/.

@mpenet
Copy link
Author

mpenet commented Dec 13, 2018

Sure, it's just not very convenient to have to dig inside jars.

@stuarthalloway
Copy link
Contributor

Hi Max! This is low priority absent a motivating use case. If we have failed to document the AWS lib in such a way that you need to read source of a dep to use it correctly, I would much prefer to start by improving the docs.

@mpenet
Copy link
Author

mpenet commented Dec 13, 2018

Understood, feel free to close this, I was merely curious about that http library.

@stuarthalloway
Copy link
Contributor

Hi Max!

Your request got me thinking about what I really want here, which is source access directly derived from project truth. I have spiked this out at https://github.com/stuarthalloway/reflector.

@mpenet
Copy link
Author

mpenet commented Dec 14, 2018

Hi Stuart,

Excellent :) Not exactly what I had in mind but I guess that will do.
It's actually quite nice to have a real world example of nav usage.

Thanks

tobias added a commit to tobias/cognitect-http-client that referenced this issue May 5, 2024
Cognitect only releases the source for this project as the jar
itself[1].

[1]: cognitect-labs/aws-api#23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants