Skip to content

Support source_profile #260

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support source_profile #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/cognitect/aws/credentials.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,11 +237,14 @@
(fetch [_]
(when (.exists f)
(try
(let [profile (get (config/parse f) profile-name)]
(let [config (config/parse f)
profile (get config profile-name)
source-profile (some->> "source_profile" (get profile) (get config))
creds-profile (or source-profile profile)]
(valid-credentials
{:aws/access-key-id (get profile "aws_access_key_id")
:aws/secret-access-key (get profile "aws_secret_access_key")
:aws/session-token (get profile "aws_session_token")}
{:aws/access-key-id (get creds-profile "aws_access_key_id")
:aws/secret-access-key (get creds-profile "aws_secret_access_key")
:aws/session-token (get creds-profile "aws_session_token")}
"aws profiles file"))
(catch Throwable t
(log/error t "Error fetching credentials from aws profiles file")))))))))
Expand Down
3 changes: 3 additions & 0 deletions test/resources/.aws/credentials
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,6 @@ aws_secret_access_key = DEFAULT_AWS_SECRET_ACCESS_KEY
aws_access_key_id = TARDIGRADE_AWS_ACCESS_KEY
aws_secret_access_key = TARDIGRADE_AWS_SECRET_ACCESS_KEY
aws_session_token = TARDIGRADE_AWS_SESSION_TOKEN

[sourced]
source_profile = default
7 changes: 6 additions & 1 deletion test/src/cognitect/aws/credentials_test.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,12 @@
(is (= {:aws/access-key-id "TARDIGRADE_AWS_ACCESS_KEY"
:aws/secret-access-key "TARDIGRADE_AWS_SECRET_ACCESS_KEY"
:aws/session-token "TARDIGRADE_AWS_SESSION_TOKEN"}
(credentials/fetch (credentials/profile-credentials-provider))))))))
(credentials/fetch (credentials/profile-credentials-provider))))))
(testing "uses source_profile."
(is (= {:aws/access-key-id "DEFAULT_AWS_ACCESS_KEY"
:aws/secret-access-key "DEFAULT_AWS_SECRET_ACCESS_KEY"
:aws/session-token nil}
(credentials/fetch (credentials/profile-credentials-provider "sourced" test-config)))))))

(deftest container-credentials-provider-test
(testing "The provider reads container metadata correctly."
Expand Down