Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add a FXAA anti-aliasing pass #1119

Merged
merged 15 commits into from
Sep 24, 2020
Merged

feat: add a FXAA anti-aliasing pass #1119

merged 15 commits into from
Sep 24, 2020

Conversation

larsmoa
Copy link
Contributor

@larsmoa larsmoa commented Sep 20, 2020

Add a simple FXAA pass after composition to reduce aliasing. This effect is virtually free and doesn't reduce performance.

image
image
(left is without FXAA, right is with FXAA)

@larsmoa larsmoa requested a review from a team as a code owner September 20, 2020 20:38
@codecov
Copy link

codecov bot commented Sep 20, 2020

Codecov Report

Merging #1119 into master will increase coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1119      +/-   ##
==========================================
+ Coverage   64.58%   64.76%   +0.17%     
==========================================
  Files          93       93              
  Lines        4137     4158      +21     
  Branches      414      414              
==========================================
+ Hits         2672     2693      +21     
  Misses       1461     1461              
  Partials        4        4              
Impacted Files Coverage Δ
...rc/datamodels/cad/rendering/EffectRenderManager.ts 63.75% <100.00%> (+3.46%) ⬆️
viewer/src/datamodels/cad/rendering/shaders.ts 100.00% <100.00%> (ø)

@github-actions
Copy link

📙 Documentation preview is available from
https://cognitedata.github.io/reveal-docs-preview/1119/docs.

@github-actions
Copy link

There were failures in the examples workflow. This usually means a visual regression test has failed. Image diffs for visual tests can be downloaded as an artifact here. If there are no artifacts there's an error somewhere else in the examples workflow. If you have made intentional changes you can update the image snapshots by running yarn snapshots:update in examples/

@larsmoa larsmoa added auto-merge auto-update Makes bulldozer automatically update this PR when there are changes to the target branch labels Sep 20, 2020
@github-actions
Copy link

There were failures in the examples workflow. This usually means a visual regression test has failed. Image diffs for visual tests can be downloaded as an artifact here. If there are no artifacts there's an error somewhere else in the examples workflow. If you have made intentional changes you can update the image snapshots by running yarn snapshots:update in examples/

@github-actions
Copy link

There were failures in the examples workflow. This usually means a visual regression test has failed. Image diffs for visual tests can be downloaded as an artifact here. If there are no artifacts there's an error somewhere else in the examples workflow. If you have made intentional changes you can update the image snapshots by running yarn snapshots:update in examples/

@github-actions
Copy link

There were failures in the examples workflow. This usually means a visual regression test has failed. Image diffs for visual tests can be downloaded as an artifact here. If there are no artifacts there's an error somewhere else in the examples workflow. If you have made intentional changes you can update the image snapshots by running yarn snapshots:update in examples/

@github-actions
Copy link

There were failures in the examples workflow. This usually means a visual regression test has failed. Image diffs for visual tests can be downloaded as an artifact here. If there are no artifacts there's an error somewhere else in the examples workflow. If you have made intentional changes you can update the image snapshots by running yarn snapshots:update in examples/

@github-actions
Copy link

There were failures in the examples workflow. This usually means a visual regression test has failed. Image diffs for visual tests can be downloaded as an artifact here. If there are no artifacts there's an error somewhere else in the examples workflow. If you have made intentional changes you can update the image snapshots by running yarn snapshots:update in examples/

@github-actions
Copy link

There were failures in the examples workflow. This usually means a visual regression test has failed. Image diffs for visual tests can be downloaded as an artifact here. If there are no artifacts there's an error somewhere else in the examples workflow. If you have made intentional changes you can update the image snapshots by running yarn snapshots:update in examples/

@github-actions
Copy link

There were failures in the examples workflow. This usually means a visual regression test has failed. Image diffs for visual tests can be downloaded as an artifact here. If there are no artifacts there's an error somewhere else in the examples workflow. If you have made intentional changes you can update the image snapshots by running yarn snapshots:update in examples/

@github-actions
Copy link

There were failures in the examples workflow. This usually means a visual regression test has failed. Image diffs for visual tests can be downloaded as an artifact here. If there are no artifacts there's an error somewhere else in the examples workflow. If you have made intentional changes you can update the image snapshots by running yarn snapshots:update in examples/

@cognite-bulldozer cognite-bulldozer bot merged commit 31b6037 into master Sep 24, 2020
@cognite-bulldozer cognite-bulldozer bot deleted the larsmoa/fxaa branch September 24, 2020 08:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants