Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

doc: add section about common issues in migration #1148

Merged
merged 3 commits into from
Sep 28, 2020
Merged

doc: add section about common issues in migration #1148

merged 3 commits into from
Sep 28, 2020

Conversation

larsmoa
Copy link
Contributor

@larsmoa larsmoa commented Sep 25, 2020

No description provided.

@larsmoa larsmoa requested a review from a team as a code owner September 25, 2020 20:04
@larsmoa larsmoa added auto-merge auto-update Makes bulldozer automatically update this PR when there are changes to the target branch labels Sep 25, 2020
@codecov
Copy link

codecov bot commented Sep 25, 2020 •
edited
Loading

Codecov Report

Merging #1148 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1148   +/-   ##
=======================================
  Coverage   64.57%   64.57%           
=======================================
  Files          93       93           
  Lines        4172     4172           
  Branches      414      414           
=======================================
  Hits         2694     2694           
  Misses       1474     1474           
  Partials        4        4

@github-actions
Copy link

📙 Documentation preview is available from
https://cognitedata.github.io/reveal-docs-preview/1148/docs.

maksnester
maksnester reviewed Sep 26, 2020
View reviewed changes
documentation/docs/migration-guide.md
outdated ThreeJS.

To fix this issue, install or update ThreeJS using the
[`three`-package](https://www.npmjs.com/package/three). This should match the version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's very bad actually. Because the version used by reveal is very internal thing. Perhaps we should just use three.js as a common dependency instead of declaring it as a peer.

maksnester
maksnester approved these changes Sep 26, 2020
View reviewed changes
Copy link
Contributor

@maksnester maksnester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And again. If you want changes immediately available you have to edit the versioned docs as well. There are not a lot of changes in master in comparison to 1.1, perhaps, we can just use the replacement script from documentation/package.json

yarn replace-1.x

@github-actions
Copy link

There were failures in the examples workflow. This usually means a visual regression test has failed. Image diffs for visual tests can be downloaded as an artifact here. If there are no artifacts there's an error somewhere else in the examples workflow. If you have made intentional changes you can update the image snapshots by running yarn snapshots:update in examples/

@cognite-bulldozer cognite-bulldozer bot merged commit f464ee4 into master Sep 28, 2020
@cognite-bulldozer cognite-bulldozer bot deleted the larsmoa/doc-common-issues branch September 28, 2020 19:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@maksnester maksnester maksnester approved these changes

Assignees
No one assigned
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larsmoa @maksnester