Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

doc: add documentation with example for clipping planes #1219

Merged
merged 37 commits into from
Nov 2, 2020
Merged

doc: add documentation with example for clipping planes #1219

merged 37 commits into from
Nov 2, 2020

Conversation

larsmoa
Copy link
Contributor

@larsmoa larsmoa commented Oct 16, 2020 •
edited
Loading

Depends on #1224

@larsmoa larsmoa requested a review from a team as a code owner October 16, 2020 20:20
@larsmoa larsmoa added auto-merge auto-update Makes bulldozer automatically update this PR when there are changes to the target branch labels Oct 16, 2020
@larsmoa larsmoa marked this pull request as draft October 16, 2020 20:21
@codecov
Copy link

codecov bot commented Oct 16, 2020 •
edited
Loading

Codecov Report

Merging #1219 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1219   +/-   ##
=======================================
  Coverage   64.01%   64.01%           
=======================================
  Files          97       97           
  Lines        4399     4399           
  Branches      423      423           
=======================================
  Hits         2816     2816           
  Misses       1580     1580           
  Partials        3        3

@github-actions
Copy link

There were failures in the examples workflow. This usually means a visual regression test has failed. Image diffs for visual tests can be downloaded as an artifact here. If there are no artifacts there's an error somewhere else in the examples workflow. If you have made intentional changes you can update the image snapshots by running yarn snapshots:update in examples/

@github-actions
Copy link

📙 Documentation preview is available from
https://cognitedata.github.io/reveal-docs-preview/1219/docs/next/.

@larsmoa larsmoa added do-not-merge Don't merge this PR yet. and removed auto-merge labels Oct 19, 2020
maksnester
maksnester reviewed Oct 19, 2020
View reviewed changes
@github-actions
Copy link

There were failures in the examples workflow. This usually means a visual regression test has failed. Image diffs for visual tests can be downloaded as an artifact here. If there are no artifacts there's an error somewhere else in the examples workflow. If you have made intentional changes you can update the image snapshots by running yarn snapshots:update in examples/

@larsmoa @maksnester
Apply suggestions from code review
28f84f0 
Co-authored-by: Maksim Nesterenko <maksim.nesterenko@cognite.com>
@larsmoa larsmoa marked this pull request as ready for review October 28, 2020 10:27
@larsmoa larsmoa added auto-merge and removed do-not-merge Don't merge this PR yet. labels Oct 28, 2020
@larsmoa larsmoa requested a review from maksnester October 28, 2020 10:28
@maksnester
Copy link
Contributor

@larsmoa there are some conflicts now.

@larsmoa larsmoa requested a review from maksnester November 2, 2020 13:10
@github-actions
Copy link

github-actions bot commented Nov 2, 2020

There were failures in the examples workflow. This usually means a visual regression test has failed. Image diffs for visual tests can be downloaded as an artifact here. If there are no artifacts there's an error somewhere else in the examples workflow. If you have made intentional changes you can update the image snapshots by running yarn snapshots:update in examples/

@github-actions
Copy link

github-actions bot commented Nov 2, 2020

There were failures in the examples workflow. This usually means a visual regression test has failed. Image diffs for visual tests can be downloaded as an artifact here. If there are no artifacts there's an error somewhere else in the examples workflow. If you have made intentional changes you can update the image snapshots by running yarn snapshots:update in examples/

maksnester
maksnester approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@maksnester maksnester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved to avoid another review and removed auto-merge, but please check my comments.

documentation/docs/demos/Cognite3DViewerDemo.tsx
@@ -11,6 +11,7 @@ import {

import { CanvasWrapper } from '@site/src/components/styled';
import { DemoProps } from '@site/src/components/DemoProps';
import { DragControls } from 'three/examples/jsm/controls/DragControls';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { DragControls } from 'three/examples/jsm/controls/DragControls';

@larsmoa larsmoa merged commit adaac84 into master Nov 2, 2020
@larsmoa larsmoa deleted the larsmoa/doc-clipping branch November 2, 2020 20:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@maksnester maksnester maksnester approved these changes

Assignees
No one assigned
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larsmoa @maksnester