[REV-40] fix: remove ts type aliases #1295
Conversation
|
There were failures in the examples workflow. This usually means a visual regression test has failed. Image diffs for visual tests can be downloaded as an artifact here. If there are no artifacts there's an error somewhere else in the examples workflow. If you have made intentional changes you can update the image snapshots by running |
|
📙 Documentation preview is available from |
That's done to avoid having aliases in production build. See * https://stackoverflow.com/a/57290924/2670121 * microsoft/TypeScript#10866
maksnester
force-pushed
the
mn/ts-aliases-removed
branch
from
3fd51e7 to
4aae304
Compare
Codecov Report
@@ Coverage Diff @@
## master #1295 +/- ##
=======================================
Coverage 64.00% 64.00%
=======================================
Files 97 97
Lines 4414 4414
Branches 425 425
=======================================
Hits 2825 2825
Misses 1585 1585
Partials 4 4
|
|
There were failures in the examples workflow. This usually means a visual regression test has failed. Image diffs for visual tests can be downloaded as an artifact here. If there are no artifacts there's an error somewhere else in the examples workflow. If you have made intentional changes you can update the image snapshots by running |
No idea why it works like that.
maksnester
force-pushed
the
mn/ts-aliases-removed
branch
from
233b48e to
c760bf5
Compare
|
There were failures in the examples workflow. This usually means a visual regression test has failed. Image diffs for visual tests can be downloaded as an artifact here. If there are no artifacts there's an error somewhere else in the examples workflow. If you have made intentional changes you can update the image snapshots by running |
That's done to avoid having aliases in the production build.
See
Please don't hate me for that 😅
put it on hold for 1.2.1
Just to summarise, currently, we use
@alias in imports. And they are left unchanged in resulting type declarations. And that is not good because some types are just replaced withanyand it doesn’t work at all in angular-cli based setups (failed with compile-time errors that fairly blame aliases).There are 3 solutions for that
../../../../../a lot@alias we can use@cognite/revealalias. It works fine, but it breaks the perfectly valid (though more rare) case when the package is installed under a different name, e.g. package.json has this"my-reveal-v1.2": "npm:@cognite/reveal@1.2.0"I personally use such things from time to time 🤷♂️ so for this case the problem remains unfixed.