Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add class color in getClasses return value #3885

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

haakonflatval-cognite
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite commented Nov 10, 2023

Type of change

Feat

Jira ticket 📘

https://cognitedata.atlassian.net/browse/

Description 📝

Add color in getClasses return value for point clouds

How has this been tested? 🔍

It hasn't

Test instructions ℹ️

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@haakonflatval-cognite haakonflatval-cognite requested a review from a team as a code owner November 10, 2023 13:56
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #3885 (bf76ff8) into master (1d22ee1) will increase coverage by 0.00%.
Report is 7 commits behind head on master.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3885   +/-   ##
=======================================
  Coverage   71.42%   71.42%           
=======================================
  Files         351      351           
  Lines       35102    35103    +1     
  Branches     2678     2677    -1     
=======================================
+ Hits        25073    25074    +1     
  Misses       9921     9921           
  Partials      108      108           
Files Coverage Δ
.../packages/pointclouds/src/ClassificationHandler.ts 89.36% <100.00%> (+0.07%) ⬆️
...packages/pointclouds/src/CognitePointCloudModel.ts 85.90% <100.00%> (ø)
viewer/packages/pointclouds/src/PointCloudNode.ts 75.00% <100.00%> (ø)

Copy link
Contributor

@christjt christjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@haakonflatval-cognite haakonflatval-cognite merged commit f0cc0e5 into master Nov 14, 2023
@haakonflatval-cognite haakonflatval-cognite deleted the hflatval/add-color-in-getclasses branch November 14, 2023 07:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants