Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: attempt at fixing MathUtils issue #4182

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

haakonflatval-cognite
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite commented Feb 13, 2024

Type of change

Chore

Jira ticket πŸ“˜

https://cognitedata.atlassian.net/browse/

Description πŸ“

Attempt at fixing MathUtils issue in react-components test

How has this been tested? πŸ”

Test instructions ℹ️

Checklist β˜‘οΈ

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@haakonflatval-cognite haakonflatval-cognite requested a review from a team as a code owner February 13, 2024 07:59
@haakonflatval-cognite haakonflatval-cognite enabled auto-merge (squash) February 13, 2024 08:07
@haakonflatval-cognite haakonflatval-cognite added the auto-update Makes bulldozer automatically update this PR when there are changes to the target branch label Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Merging #4182 (2cc44cc) into master (5fc7fca) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4182   +/-   ##
=======================================
  Coverage   71.31%   71.32%           
=======================================
  Files         373      373           
  Lines       38149    38149           
  Branches     2762     2763    +1     
=======================================
+ Hits        27207    27209    +2     
+ Misses      10834    10832    -2     
  Partials      108      108           
Files Coverage Ξ”
...ra-manager/src/Flexible/FlexibleControlsOptions.ts 12.50% <100.00%> (ΓΈ)
...wer/packages/tools/src/HtmlOverlay/BucketGrid2D.ts 96.29% <100.00%> (ΓΈ)

... and 1 file with indirect coverage changes

@haakonflatval-cognite haakonflatval-cognite merged commit 872b482 into master Feb 13, 2024
23 checks passed
@haakonflatval-cognite haakonflatval-cognite deleted the hflavtal/fix-mathutils-issue branch February 13, 2024 08:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants