Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix things in the StationaryCameraManager #4196

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

nilscognite
Copy link
Contributor

Fix 2 things:

Reverse direction in the 360 rotations (Kerem's order)
Make mouse dragging possible outside the browser. (Kerem's order)

@nilscognite nilscognite requested a review from a team as a code owner February 14, 2024 20:35
@nilscognite nilscognite changed the title Update StationaryCameraManager.ts Fix things in the StationaryCameraManager Feb 14, 2024
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Merging #4196 (dc37a63) into master (e3009f5) will decrease coverage by 0.01%.
The diff coverage is 37.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4196      +/-   ##
==========================================
- Coverage   71.32%   71.31%   -0.01%     
==========================================
  Files         373      373              
  Lines       38149    38148       -1     
  Branches     2763     2762       -1     
==========================================
- Hits        27209    27207       -2     
- Misses      10832    10833       +1     
  Partials      108      108              
Files Coverage Δ
...ages/camera-manager/src/StationaryCameraManager.ts 39.74% <37.50%> (+0.12%) ⬆️

... and 1 file with indirect coverage changes

@nilscognite nilscognite enabled auto-merge (squash) February 15, 2024 15:09
@nilscognite nilscognite merged commit 6cfc441 into master Feb 15, 2024
14 checks passed
@nilscognite nilscognite deleted the np/stasionary-camera-control branch February 15, 2024 15:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants