Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Improve the way the camera is moving when double click #4206

Merged
merged 11 commits into from
Feb 19, 2024
Merged

Improve the way the camera is moving when double click #4206

merged 11 commits into from
Feb 19, 2024

Conversation

nilscognite
Copy link
Contributor

@nilscognite nilscognite commented Feb 16, 2024 •
edited
Loading

  • Just adjusting the algorithm when double click and move the camera.
  • Initialize automatically if not set target and direction before the camera starts.

@nilscognite nilscognite requested a review from a team as a code owner February 16, 2024 14:00
@codecov Codecov
Copy link

codecov bot commented Feb 16, 2024 •
edited
Loading

Codecov Report

Merging #4206 (6bd6f22) into master (9a612a4) will decrease coverage by 0.05%.
The diff coverage is 18.42%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4206      +/-   ##
==========================================
- Coverage   71.30%   71.26%   -0.05%     
==========================================
  Files         375      375              
  Lines       38260    38290      +30     
  Branches     2764     2766       +2     
==========================================
+ Hits        27281    27287       +6     
- Misses      10870    10894      +24     
  Partials      109      109
Files Coverage Δ
...es/camera-manager/src/Flexible/FlexibleControls.ts 39.00% <42.85%> (+0.03%) ⬆️
...mera-manager/src/Flexible/FlexibleCameraManager.ts 46.35% <4.16%> (-1.32%) ⬇️

@nilscognite nilscognite marked this pull request as draft February 16, 2024 14:15
@nilscognite nilscognite marked this pull request as ready for review February 19, 2024 10:39
@nilscognite nilscognite enabled auto-merge (squash) February 19, 2024 12:23
@nilscognite nilscognite added the auto-update Makes bulldozer automatically update this PR when there are changes to the target branch label Feb 19, 2024
@nilscognite nilscognite disabled auto-merge February 19, 2024 13:08
@nilscognite nilscognite enabled auto-merge (squash) February 19, 2024 13:09
anders-hopland
anders-hopland approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@anders-hopland anders-hopland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nilscognite nilscognite disabled auto-merge February 19, 2024 13:22
@nilscognite @anders-hopland
Update viewer/packages/camera-manager/src/Flexible/FlexibleCameraMana…
6bd6f22 
…ger.ts

Co-authored-by: anders-hopland <andershopl@hotmail.com>
@nilscognite nilscognite enabled auto-merge (squash) February 19, 2024 13:40
@nilscognite nilscognite merged commit a73df26 into master Feb 19, 2024
13 checks passed
@nilscognite nilscognite deleted the np/camera-fixes branch February 19, 2024 13:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@anders-hopland anders-hopland anders-hopland approved these changes

@haakonflatval-cognite haakonflatval-cognite haakonflatval-cognite approved these changes

Assignees
No one assigned
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nilscognite @anders-hopland @haakonflatval-cognite