Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Fixing 360 image bugs and connection to the new Architecture + Upgrade to new version #4832

Merged
merged 10 commits into from
Oct 30, 2024

Conversation

nilscognite
Copy link
Contributor

@nilscognite nilscognite commented Oct 29, 2024

Type of change

Fix

Description 📝

This fixes some issues when tested it on Fusion

  1. Enter didn't work - added a break in the swich.
  2. Need to go out using transition.
  3. Renamed some of the functions according to Pramod's code review.
  4. Clear the history list when removing 360 image. This is just a quick solve of a inconstancy problem in the history. I don't think the user will feel this as a missing feature.

How has this been tested? 🔍

Test instructions ℹ️

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@nilscognite nilscognite requested a review from a team as a code owner October 29, 2024 20:02
@nilscognite nilscognite changed the title feat: Fixing 360 image bugs and connection to the new Architecture feat: Fixing 360 image bugs and connection to the new Architecture + Upgrade to new version Oct 30, 2024
@pramodcog
Copy link
Contributor

pramodcog commented Oct 30, 2024

@nilscognite These are fixes or improvements in the PR, we should only update the the version to 4.20.1 and also change tag to fix or improvement in the summary.
Above details is important, because when we release new version of Reveal, release docs will be published which public users refer, so the above change is needed

@nilscognite
Copy link
Contributor Author

@nilscognite These are fixes or improvements in the PR, we should only update the the version to 4.20.1 and also change tag to fix or improvement in the summary. Above details is important, because when we release new version of Reveal, release docs will be published which public users refer, so the above change is needed

I updated the API so it fits the name you told me in the last PR review. The api doc is also updated.

@nilscognite nilscognite changed the title feat: Fixing 360 image bugs and connection to the new Architecture + Upgrade to new version fix: Fixing 360 image bugs and connection to the new Architecture + Upgrade to new version Oct 30, 2024
Copy link
Contributor

@pramodcog pramodcog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nilscognite nilscognite enabled auto-merge (squash) October 30, 2024 11:43
@nilscognite nilscognite disabled auto-merge October 30, 2024 11:46
@nilscognite nilscognite merged commit eb0c58f into master Oct 30, 2024
14 checks passed
@nilscognite nilscognite deleted the np/reveal-360-images branch October 30, 2024 11:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants