-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add credentials
parameter to read_gbq
#78
Conversation
Hm, I'd expect this to work, but personally I'd prefer the API to take credentials object, rather than taking the dict. This would give more flexibility, and be more consistent with Google APIs. |
Thanks for taking a look at this @ntabris
My guess is that folks coming from Dask will be used to passing as |
Consistency with what we already have in this package seems important, yeah! More important than these other considerations. |
Sure. |
|
@jrbourbeau thanks for adding a fix so fast!! |
I'm going to merge this in as the hanging Python 3.8 build on macOS is unrelated to the changes in this PR (xref #80) |
This PR adds a new
credentials=
kwarg toread_gbq
and pipes it down to the appropriate Google client library calls. For testing, I've copied our existingtest_to_gbq_with_credentials
test (which testing the same thing, but forto_gbq
) and added aread_gbq
where we passcredentials
through.This seems like the right thing to do, but I'm not very familiar with how Google handles auth. cc @ntabris who has more experience in that department
Closes #77