Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fixed closing bracket typo #243

Merged
merged 1 commit into from
May 24, 2022

Conversation

brmanuel
Copy link
Contributor

Fixed the below typo.
Note that without the fix, all objective parameters with value < 1e-20 are discarded.
With the fix, all objective parameters with absolute value < 1e-20 are discarded.

@CLAassistant
Copy link

CLAassistant commented Jan 31, 2022

CLA assistant check
All committers have signed the CLA.

@sebheger
Copy link
Collaborator

Thanks for your contribution @brmanuel

  • Could please give commit a more speaking name like "Fixed closing bracket typo at objective values (gurobi)"?
  • Please a test case, where you have certain small and negative objective values. You can query the resulting linExpr for assertion

@sebheger sebheger added this to the Release 1.14.0 milestone Mar 23, 2022
@sebheger sebheger merged commit cdbf376 into coin-or:master May 24, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants