Add /block idempotency requirement #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a requirement that all calls to the /block endpoint be idempotent when identifying a block by hash. This ensures blocks are inalterable and clients can safely assume that once they've received a specific block from a Rosetta implementation that block won't change.
matheusd
force-pushed
the
inalterable-blocks
branch
from
f87217c to
d909dc6
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a requirement that all calls to the /block endpoint be
idempotent when identifying a block by hash.
This ensures blocks are inalterable and clients can safely assume that
once they've received a specific block from a Rosetta implementation
that block won't change.
The discussion that prompted this is here