Fix for issue #226 #232
Merged
Fix for issue #226 #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think that the three columns causing problems with uniprot get_df() are: 'ft_ca_bind' 'ft_np_bind' 'ft_metal' After commenting them, get_df() woks fine again.
|
@GianArauz thanks a lot for this pull request. Well, yes, you proceed correctly. You have created a forked and submitted a pull request. I have approved the workflow so that is will now run the tests for you. I'll double check the uniprot documentation before though. looks like they have changed the API very recently. I may have comments by tomorrow before merging the pull request. thanks again for spotting and fixing this issue. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that the three columns causing problems with uniprot
get_df()are:'ft_ca_bind''ft_np_bind''ft_metal'After commenting them,
get_df()works fine again.PS: This is my first (or second) pull request. Please, let me know if I proceed correctly and sorry in advance if something is not adequate.