Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Switch to workflow_call for GitHub Actions CI #613

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Feb 7, 2024

This change switches colcon-core to use the new workflow_call-based solution for centralized CI definitions. It substantially reduces the boilerplate needed in each repository.

Once this change is merged, I'll make a corresponding change in each colcon extension.

@cottsay cottsay self-assigned this Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f7dfec7) 83.32% compared to head (04cee95) 83.37%.

❗ Current head 04cee95 differs from pull request most recent head 584eae5. Consider uploading reports for the commit 584eae5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #613      +/-   ##
==========================================
+ Coverage   83.32%   83.37%   +0.05%     
==========================================
  Files          66       66              
  Lines        3789     3789              
  Branches      737      737              
==========================================
+ Hits         3157     3159       +2     
+ Misses        557      556       -1     
+ Partials       75       74       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cottsay cottsay force-pushed the cottsay/workflow-call branch from 04cee95 to adaaf91 Compare February 7, 2024 17:53
Copy link
Contributor

@claraberendsen claraberendsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

@cottsay cottsay merged commit 9854d54 into master Feb 7, 2024
40 checks passed
@delete-merged-branch delete-merged-branch bot deleted the cottsay/workflow-call branch February 7, 2024 21:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants