Support upstream catkin_pkg deb #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OSRF-provided python3-catkin-pkg-modules is still preferred, but we should allow use of the upstream package as well. Either will work fine with colcon-ros.
nuclearsandwich
approved these changes
Apr 19, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OSRF-provided
python3-catkin-pkg-modulesis still preferred, but we should allow use of the upstream package as well. Either will work fine withcolcon-ros.The motivation behind this change is to allow the Package Cloud repository to be usable without the contents of the ROS bootstrap repository, which is where
python3-catkin-pkg-modulescomes from.