Fix fix_missing_cell_labels() when no cells need fixing.

cole-trapnell-lab · Jun 19, 2024 · eed1cd6 · eed1cd6
1 parent 040397b
commit eed1cd6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: monocle3
 Title: Clustering, Differential Expression, and Trajectory Analysis for
     Single-Cell RNA-Seq
-Version: 1.4.19
+Version: 1.4.20
 Authors@R: c(
     person(given = "Hannah",
            family = "Pliner",

diff --git a/R/label_transfer.R b/R/label_transfer.R
@@ -478,6 +478,12 @@ fix_missing_cell_labels <- function(cds,
   assertthat::assert_that(from_column_name %in% colnames(colData(cds)),
                           msg=paste0('from_column_name \'', from_column_name, '\' is not in the cds colData'))
 
+  if(sum(is.na(colData(cds)[[from_column_name]])) == 0) {
+    if(to_column_name != from_column_name)
+      colData(cds)[[to_column_name]] <- colData(cds)[[from_column_name]]
+    return(cds)
+  }
+
   if(reduction_method == 'UMAP')
     nn_control_default <- get_global_variable('nn_control_annoy_euclidean')
   else