fix(v3): dirty union bug

src/__tests__/unions.test.ts

@@ -32,17 +32,29 @@ test("return valid over invalid", () => {
   });
 });
 
-test("return dirty result over aborted", () => {
+test("union with dirty result", () => {
   const result = z
     .union([z.number(), z.string().refine(() => false)])
     .safeParse("a");
   expect(result.success).toEqual(false);
   if (!result.success) {
-    expect(result.error.issues).toEqual([
+    expect(result.error.issues).toMatchObject([
       {
-        code: "custom",
-        message: "Invalid input",
-        path: [],
+        code: "invalid_union",
+        unionErrors: [
+          expect.objectContaining({
+            code: "invalid_type",
+            expected: "number",
+            received: "string",
+            path: [],
+            message: "Expected number, received string",
+          }),
+          expect.objectContaining({
+            code: "custom",
+            message: "Invalid input",
+            path: [],
+          }),
+        ],
       },
     ]);
   }

src/types.ts

@@ -2987,8 +2987,6 @@ export class ZodUnion<T extends ZodUnionOptions> extends ZodType<
         })
       ).then(handleResults);
     } else {
-      let dirty: undefined | { result: DIRTY<any>; ctx: ParseContext } =
-        undefined;
       const issues: ZodIssue[][] = [];
       for (const option of options) {
         const childCtx: ParseContext = {
@@ -3007,20 +3005,13 @@ export class ZodUnion<T extends ZodUnionOptions> extends ZodType<
 
         if (result.status === "valid") {
           return result;
-        } else if (result.status === "dirty" && !dirty) {
-          dirty = { result, ctx: childCtx };
         }
 
         if (childCtx.common.issues.length) {
           issues.push(childCtx.common.issues);
         }
       }
 
-      if (dirty) {
-        ctx.common.issues.push(...dirty.ctx.common.issues);
-        return dirty.result;
-      }
-
       const unionErrors = issues.map((issues) => new ZodError(issues));
       addIssueToContext(ctx, {
         code: ZodIssueCode.invalid_union,