Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

FIX: Git and GitHub Workflow | 3rd Issue Ticket Task | Working with GitHub web UI #14

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

BA-atomic
Copy link
Contributor

General checklist

  • My pull request adheres to the Collabo Community pull request guidelines.
  • I have read and understood the Pull request guideline extension section found at the bottom of this pull request description/body.
  • I have replaced the dummy text under the subheading Testing checklist below with the testing checklist from the issue ticket I'm working on.

Testing checklist

  • Here's a link to my approved 2nd task pull request: Fix: Git and GitHub Collabo | 2nd Issue Ticket Task | Working with GitHub web UI #8
  • My branch for this task assignment is created from the develop branch, and the name of my branch is a mix of @GH- and the ticket's issue number (no # sign and no space in there).
  • I have renamed the gitcollab-ui-task.md file in my own folder to gitcollab-web-ui-task.md
  • I certify that I ran my checklist.

Pull request guideline extension

Note

Do not remove this note and the sections below. This talks about extra things to take note of, in addition to the directions given in the Collabo Community pull request guidelines.

We appreciate the time taken to help tackle issue tickets within the Collabo Community. Please go ahead to submit your pull request even if it is not yet completed, and push to the pull request actively. This will allow us to know that you have not abandoned the issue ticket. However, you should only alert reviewers about your pull request as explained below, to avoid flooding their GitHub notifications unnecessarily.

"Ready for review" implies that things are working as expected, according to how it is specified in the issue ticket you are working on. Ensure that you test the code that you are working on, that it works as expected. Don't just request for review when your pull request is not yet done and working.

The only time you should be making people review something incomplete is: if you want to show them what's not working, so that they can send help or guidance. If this is the case, be explicit about this in our Discord community or in the comment of your pull request (after you have submitted the pull request).

Requesting review: For this repository, the review team to request review from is the @collabo-community/maintainers team. Once your pull request is ready for review, select this review team from the reviewers dropdown on this pull request. If you don't have access to the reviewer's dropdown, tag this review team in the comment of this pull request.

@BA-atomic
Copy link
Contributor Author

Hi @collabo-community/maintainers, this PR is ready for review.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant