Fix: Git and GitHub Workflow | 1st Issue Ticket Task | Working with GitHub web UI #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@collabo-community/maintainers This PR is ready for review |
Ifycode
requested changes
Feb 20, 2025
There was a problem hiding this comment.
Smooth work 👍🏼 @Danbaba1 , three (3) things though:
- According to our PR template, the screenshot section comes before the testing checklist: https://github.com/collabo-community/good-first-issue-solutions/blob/develop/.github/pull_request_template.md
- About your testing checklist, it's not everything in there that is text throughout. Some things in there are enclosed in inline code blocks.
- Your submission looks correct. But the ticket gave specific instructions on how the screenshot should be taken. Some parts of yours are cropped off - it's not just your file we want to see.
Please check the example screenshot to also see what reviewers expect to see @Danbaba1
Extra note: If your computer screen is too small, please use the browser zoom feature to zoom up to the point where you can capture the screen as directed.
|
@Ifycode I will make the changes noted. Thank you. |
|
@collabo-community/maintainers This PR is ready for review |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the following changes
General checklist
Screenshot
Testing checklist
developbranch, and the name of my branch is a mix of@GH-and the ticket's issue number (no # sign and no space in there).@and my GitHub user name has been created in the root of thegood-first-issue-solutionsrepository.gitcollab-ui-task.mdis in the root of my newly created folder.gitcollab-ui-task.mdfile uses the content of the ui-task.md file found at the root of the@gitcollab-learnfolder. I have also followed the directions in there to replace text where necessary.Pull request guideline extension
Note
Do not remove this note and the sections below. This talks about extra things to take note of, in addition to the directions given in the Collabo Community pull request guidelines.
We appreciate the time taken to help tackle issue tickets within the Collabo Community. Please go ahead to submit your pull request even if it is not yet completed, and push to the pull request actively. This will allow us to know that you have not abandoned the issue ticket. However, you should only alert reviewers about your pull request as explained below, to avoid flooding their GitHub notifications unnecessarily.
"Ready for review" implies that things are working as expected, according to how it is specified in the issue ticket you are working on. Ensure that you test the code that you are working on, that it works as expected. Don't just request for review when your pull request is not yet done and working.
The only time you should be making people review something incomplete is: if you want to show them what's not working, so that they can send help or guidance. If this is the case, be explicit about this in our Discord community or in the comment of your pull request (after you have submitted the pull request).
Requesting review: For this repository, the review team to request review from is the
@collabo-community/maintainersteam. Once your pull request is ready for review, select this review team from the reviewers dropdown on this pull request. If you don't have access to the reviewer's dropdown, tag this review team in the comment of this pull request.