Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

FIX: Git and GitHub Collabo | 1st Issue Ticket Task | Working with GitHub web UI #4

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

BA-atomic
Copy link
Contributor

This pull request makes the following changes

General checklist

  • My pull request adheres to the Collabo Community pull request guidelines.
  • I have read and understood the Pull request guideline extension section found at the bottom of this pull request description/body.
  • I have replaced the dummy text under the subheading Testing checklist below with the testing checklist from the issue ticket I'm working on.

Testing checklist

  • Confirmed that the branch was created from the develop branch.
  • Verified that the branch name adheres to the naming format: @gh-4 (without the # sign or spaces).
  • Created a new folder in the root of the repository with the correct name format: @BA-atomic.
  • Ensured the file gitcollab-ui-task.md was created in the root of the newly created folder.
  • Copied the content of the ui-task.md file into gitcollab-ui-task.md and replaced the required text as specified.
  • Verified that no other files or folders outside the assigned folder were altered unintentionally.
  • Before committing changes, took a full-screen screenshot of the browser showing the GitHub Web Interface with all necessary elements visible (expanded browser, scrolled to the top).

Screenshot

Screenshot (128)

Pull request guideline extension

Note

Do not remove this note and the sections below. This talks about extra things to take note of, in addition to the directions given in the Collabo Community pull request guidelines.

We appreciate the time taken to help tackle issue tickets within the Collabo Community. Please go ahead to submit your pull request even if it is not yet completed, and push to the pull request actively. This will allow us to know that you have not abandoned the issue ticket. However, you should only alert reviewers about your pull request as explained below, to avoid flooding their GitHub notifications unnecessarily.

"Ready for review" implies that things are working as expected, according to how it is specified in the issue ticket you are working on. Ensure that you test the code that you are working on, that it works as expected. Don't just request for review when your pull request is not yet done and working.

The only time you should be making people review something incomplete is: if you want to show them what's not working, so that they can send help or guidance. If this is the case, be explicit about this in our Discord community or in the comment of your pull request (after you have submitted the pull request).

Requesting review: For this repository, the review team to request review from is the @collabo-community/maintainers team. Once your pull request is ready for review, select this review team from the reviewers dropdown on this pull request. If you don't have access to the reviewer's dropdown, tag this review team in the comment of this pull request.

@BA-atomic
Copy link
Contributor Author

@collabo-community/maintainers, changes made and this PR is now ready for review

Copy link
Member

@Ifycode Ifycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏼
Approved! 🎉

@Ifycode Ifycode merged commit 0347893 into collabo-community:develop Jan 18, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants