Replace RequestStore with ActiveSupport::CurrentAttributes
#673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👏 thank you @the-spectator! |
|
A friendly bump for the maintainers! |
danielmorrison
approved these changes
Nov 6, 2023
|
I have merge regrets. I stupidly didn't wait for all the tests to pass. |
|
I reverted this. I'd love to merge a version of it again, but not with all the test failures we were seeing. Unfortunately, chasing down those test failures isn't high on my priority list. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup of #669
This PR is an attempt to use
ActiveSupport::CurrentAttributesinstead of theRequestStoregem.