Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement support for "Von Kries 2020" chromatic adaptation transform. #891

Open
KelSolaar opened this issue Nov 1, 2021 · 5 comments
Open

Comments

@KelSolaar
Copy link
Member

References

@KelSolaar KelSolaar added this to the v0.4.0 milestone Nov 1, 2021
@starkfan007
Copy link

Is this issue still active @KelSolaar ? If so, I hope to give a contribution for it.
Thanks.

@KelSolaar
Copy link
Member Author

Hi @starkfan007, yes it is still up!

@starkfan007
Copy link

Hi @KelSolaar, I am a bit confused about some of the statements in the paper.
The first question is how to understand the previous state and how to define the previous state in the code. I didn't understand this part very well.
The second question is about D factor. There is no corresponding calculation formula in the paper. According to Table 1, D factor seems to be an empirical parameter adjusted through different model experiments.
Thanks!

@KelSolaar
Copy link
Member Author

Hello @starkfan007,

Sorry, I haven't had time to check the paper details yet! Let me get back to you!

@KelSolaar KelSolaar modified the milestones: v0.4.0, v0.4.1, v0.4.2 Feb 19, 2022
@tjdcs
Copy link
Contributor

tjdcs commented May 25, 2022

I'm familiar with this paper. But it would be much easier for me to discuss on a call or voice chat. Feel free to reach out.

@KelSolaar KelSolaar modified the milestones: v0.4.2, v0.4.3 Nov 27, 2022
@KelSolaar KelSolaar modified the milestones: v0.4.3, v0.4.4 Aug 25, 2023
@KelSolaar KelSolaar modified the milestones: v0.4.4, v0.4.5 Dec 19, 2023
@KelSolaar KelSolaar modified the milestones: v0.4.5, v0.4.6, v0.4.7 Oct 10, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants