Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

PR: Implement support for "vK20" chromatic adaptation transform. #1131

Merged
merged 5 commits into from
May 26, 2024

Conversation

KelSolaar
Copy link
Member

Summary

This PR implements support for Von Tries (2020) chromatic adaptation transform.

References #891.

Preflight

Code Style and Quality

  • Unit tests have been implemented and passed.
  • Pyright static checking has been run and passed.
  • Pre-commit hooks have been run and passed.
  • [N/A] New transformations have been added to the Automatic Colour Conversion Graph.
  • New transformations have been exported to the relevant namespaces, e.g. colour, colour.models.

Documentation

  • New features are documented along with examples if relevant.
  • The documentation is Sphinx and numpydoc compliant.

@KelSolaar KelSolaar added this to the v0.4.3 milestone Apr 6, 2023
@KelSolaar KelSolaar requested a review from tjdcs April 6, 2023 11:15
@coveralls
Copy link

coveralls commented Apr 6, 2023

Coverage Status

coverage: 99.978%. remained the same
when pulling 3d30335 on feature/vk20
into 415b517 on develop.

@tjdcs
Copy link
Contributor

tjdcs commented Apr 10, 2023

We are heading into NAB so I am totally slammed for time but I will try to review after NAB in 2 weeks.

@KelSolaar KelSolaar modified the milestones: v0.4.3, v0.4.4 Aug 25, 2023
@tjdcs
Copy link
Contributor

tjdcs commented Oct 27, 2023

I just asked Mark and Che Shen for any updates on the vk20 work before reviewing this

@KelSolaar KelSolaar force-pushed the feature/vk20 branch 2 times, most recently from 075d64e to 9bb64c5 Compare May 23, 2024 08:44
@KelSolaar
Copy link
Member Author

Merging this one as I think it is correct, quoting Mark:

"It’s really just the weighted sum of three whites to obtain the normalizing white for von Kries"

@KelSolaar KelSolaar merged commit efb651e into develop May 26, 2024
32 checks passed
@KelSolaar KelSolaar deleted the feature/vk20 branch May 26, 2024 06:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants