Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: Support customize server and socket options of undertow #161

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

He-Pin
Copy link
Contributor

@He-Pin He-Pin commented Jan 18, 2025

Motivation:
Add support for customized server and socket options of undertow
Modification:

Modification:
add serverOptions and socketOptions method.

Another option is define an def setup(builder:Builder):Unit = () method.

@He-Pin He-Pin force-pushed the reuseAddr branch 2 times, most recently from 4d499a1 to f51211c Compare January 18, 2025 12:33
@lihaoyi
Copy link
Member

lihaoyi commented Jan 18, 2025

Can you explain in the PR what those flags do?

@He-Pin He-Pin changed the title chore: Set reuseAddr by default for undertow. chore: Support customize server and socket options of undertow Jan 18, 2025
@He-Pin
Copy link
Contributor Author

He-Pin commented Jan 18, 2025

Have dropped the old way, and added two methods for overriding.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants