Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Re-run netty maven comparison with updated flags #3871

Closed
lihaoyi opened this issue Oct 29, 2024 · 0 comments · Fixed by #3918
Closed

Re-run netty maven comparison with updated flags #3871

lihaoyi opened this issue Oct 29, 2024 · 0 comments · Fixed by #3918
Milestone

Comments

@lihaoyi
Copy link
Member

lihaoyi commented Oct 29, 2024

We can either disable RevAPI and Animal Sniffer in the Maven build, or enable them in our Mill build. Either would help ensure a fair comparison. My cursory indicates the comparative numbers shouldn't change by too much.

lihaoyi added a commit that referenced this issue Nov 7, 2024
…l benchmark (#3918)

Fixes #3871. I also moved the
`./mvnw clean` into a separate command to avoid counting that time spent
towards the Maven benchmark


The differences between Maven and Mill are no longer quite as stark, but
they are still very significant. The Mill benchmarks are about the same,
as expected, so I skipped running the last few

For the Gatling/SBT comparison, SBT `compile` does not compile test
classes, while `test:compile` does. So Using SBT's `test:compile` is
necessary for an apples-to-apples comparison with Mill's `__.compile`
which does compile test classes
@lefou lefou added this to the 0.12.2 milestone Nov 7, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants