Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use docker image hash to determine if build should rerun #3124

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

nrktkt
Copy link
Contributor

@nrktkt nrktkt commented Apr 17, 2024

previously the docker build would re-run if the user had pullBaseImage set to true. now it always checks the remote repository for a new version of the base image, but only re-runs the build if the base image hash has changed

Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@lefou
Copy link
Member

lefou commented Apr 19, 2024

@nrktkt Can you please reformat your changes?

@lefou lefou merged commit 6c814c7 into com-lihaoyi:main Apr 23, 2024
35 of 36 checks passed
@lefou lefou added this to the 0.11.8 milestone Apr 23, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants