-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Support build.sc
in Bloop
#3208
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to seem some test coverage for a meta-build support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The newly added test isn't really using a meta-build.
You are right! I was confusing the normal mill build with the meta-build. |
Yeah, makes sense. If you can move this message into a PR description, we should be good to merge it. I assume full support for meta-builds should be around the corner, just by the fact that the bootstrap build works. What's needed for confidence is a test case with a meta-build. But this can be another PR. |
After Mill
0.11
mill-contrib-bloop
stopped supporting the build module.Now
BloopImpl
gets a sequence ofEvaluator
s and gets all modules for all the evaluators inEvaluator.allBootstrapEvaluators
, so it supports the build module again.Pull Request: #3208