Re-implement ticker prefixes using key: Seq[String]
concatenation
#3697
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-implements the ticker log prefixes that were left out in #3577, both for meta-build prefixes and nested-evaluation prefixes, e.g. the log prefix now looks like
[build.mill-1]
[mill-build/build.mill-1]
etc.We no longer need
dynamicTickerPrefix
, because we now perform this context management by wrapping nestedPrefixLogger
sRequired some gross mangling to consolidate
Logger
andColorLogger
interfaces in order to make things properly stackableWe needed to move the aggregation of keys to a top-down process, rather than bottom up, since it is not easy to take an already prefixed line
[1] my logs line
and append to the prefix[1-2] my logs line
. Thus we need to make sure the log line is properly prefixed at the bottom-most logger, and the log line is passed up viaunprefixedSystemStreams
to avoid redundant prefixing