Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix spawning of terminfo thread in server mode #3833

Merged
merged 5 commits into from
Oct 24, 2024

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Oct 24, 2024

Previously we only spawned the terminfo updater when spawning the Mill server process, but that only handles the no-server case and first-time-spawning-server case, without handling the subsequently-re-use-server case.

This moves the logic into a helper method so we can call it from both server and no-server launchers at the first point at which we have a dedicated serverDir available. Since the serverDIr is only available deep inside the ServerLauncher object, as it needs to do the work of testing different locks to pick a server, we add a preRun hook that we can override to start the terminfo updater thread

@lihaoyi lihaoyi merged commit d6d672b into com-lihaoyi:main Oct 24, 2024
24 checks passed
@lefou lefou added this to the 0.12.1 milestone Oct 24, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants