Fix spawning of terminfo thread in server mode #3833
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we only spawned the terminfo updater when spawning the Mill server process, but that only handles the no-server case and first-time-spawning-server case, without handling the subsequently-re-use-server case.
This moves the logic into a helper method so we can call it from both server and no-server launchers at the first point at which we have a dedicated
serverDir
available. Since theserverDIr
is only available deep inside theServerLauncher
object, as it needs to do the work of testing different locks to pick a server, we add apreRun
hook that we can override to start the terminfo updater thread