Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Revert "Always check available() in InputPumper to avoid burning CPU (#4095)" #4159

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Dec 18, 2024

Fixes #4158

This hits some JVM limitations that significantly slow down the process exit, unnecessarily. Added a comment to the code so we don't forget again

@lihaoyi lihaoyi marked this pull request as ready for review December 18, 2024 05:39
@lihaoyi lihaoyi merged commit d3e5d50 into com-lihaoyi:main Dec 18, 2024
25 of 26 checks passed
@lefou lefou added this to the 0.12.5 milestone Dec 18, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

time ./mill version startup time regression in 0.12.4
2 participants