address comments

comet-ml · Jan 27, 2025 · dde95f8 · dde95f8
1 parent cde6570
commit dde95f8
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/apps/opik-backend/src/main/java/com/comet/opik/domain/CommentService.java b/apps/opik-backend/src/main/java/com/comet/opik/domain/CommentService.java
@@ -24,7 +24,7 @@ public interface CommentService {
 
     Mono<Void> update(UUID commentId, Comment comment);
 
-    Mono<Long> delete(BatchDelete batchDelete);
+    Mono<Void> delete(BatchDelete batchDelete);
 
     Mono<Long> deleteByEntityIds(CommentDAO.EntityType entityType, Set<UUID> entityIds);
 }
@@ -68,8 +68,8 @@ public Mono<Void> update(@NonNull UUID commentId, @NonNull Comment comment) {
     }
 
     @Override
-    public Mono<Long> delete(@NonNull BatchDelete batchDelete) {
-        return commentDAO.deleteByIds(batchDelete.ids());
+    public Mono<Void> delete(@NonNull BatchDelete batchDelete) {
+        return commentDAO.deleteByIds(batchDelete.ids()).then();
     }
 
     @Override

diff --git a/...urces/utils/resources/BaseTestClient.java → .../resources/BaseCommentResourceClient.java b/...urces/utils/resources/BaseTestClient.java → .../resources/BaseCommentResourceClient.java
@@ -18,7 +18,7 @@
 import static org.assertj.core.api.Assertions.assertThat;
 
 @RequiredArgsConstructor
-public abstract class BaseTestClient {
+public abstract class BaseCommentResourceClient {
     protected final String RESOURCE_PATH;
     protected final ClientSupport client;
     protected final String baseURI;

diff --git a/...ackend/src/test/java/com/comet/opik/api/resources/utils/resources/SpanResourceClient.java b/...ackend/src/test/java/com/comet/opik/api/resources/utils/resources/SpanResourceClient.java
@@ -22,7 +22,7 @@
 import static com.comet.opik.infrastructure.auth.RequestContext.WORKSPACE_HEADER;
 import static org.assertj.core.api.Assertions.assertThat;
 
-public class SpanResourceClient extends BaseTestClient {
+public class SpanResourceClient extends BaseCommentResourceClient {
 
     public SpanResourceClient(ClientSupport client, String baseURI) {
         super("%s/v1/private/spans", client, baseURI);

diff --git a/...ckend/src/test/java/com/comet/opik/api/resources/utils/resources/TraceResourceClient.java b/...ckend/src/test/java/com/comet/opik/api/resources/utils/resources/TraceResourceClient.java
@@ -24,7 +24,7 @@
 import static com.comet.opik.infrastructure.auth.RequestContext.WORKSPACE_HEADER;
 import static org.assertj.core.api.Assertions.assertThat;
 
-public class TraceResourceClient extends BaseTestClient {
+public class TraceResourceClient extends BaseCommentResourceClient {
 
     public TraceResourceClient(ClientSupport client, String baseURI) {
         super("%s/v1/private/traces", client, baseURI);