[OPIK-743] Fix properties naming strategy #1035
Merged
+38
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrescrz
previously approved these changes
Jan 14, 2025
|
|
||
| import java.time.Instant; | ||
| import java.util.List; | ||
| import java.util.UUID; | ||
|
|
||
| @Data | ||
| @Getter |
There was a problem hiding this comment.
Remind me about this. @Data implements all typical Java methods, such as toString, equals & hascode etc. why are we losing that?
There was a problem hiding this comment.
Good catch. I actually want to make it immutable, but I can achieve this by making the properties final and avoiding having to add @tostring and @EquaslAndHashCode
andrescrz
approved these changes
Jan 14, 2025
| @@ -19,17 +21,20 @@ | |||
|
|
|||
| import static com.comet.opik.api.AutomationRuleEvaluatorLlmAsJudge.LlmAsJudgeCode; | |||
|
|
|||
| @EqualsAndHashCode(callSuper = true) | |||
| @Data | |||
There was a problem hiding this comment.
What about this other @Data annotation being removed?
There was a problem hiding this comment.
No, sorry. This has the equals and hash code and is to string because it needs the call to super. So it's okay.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fix properties naming strategy
Issues
OPIK-743