Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[DEV-2536] add python-backend service to helm chart #1089

Merged
merged 4 commits into from
Jan 21, 2025
Merged

[DEV-2536] add python-backend service to helm chart #1089

merged 4 commits into from
Jan 21, 2025
+125 −9

Conversation

liyaka
Copy link
Contributor

@liyaka liyaka commented Jan 20, 2025 •
edited
Loading

Details

Added opik-python-backend application to the helm chart:

  • service
  • privileged pod
  • network policies

Issues

Resolves #

Testing

Documentation

@liyaka liyaka requested review from a team as code owners January 20, 2025 16:54
andrescrz
andrescrz reviewed Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@andrescrz andrescrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM. Just an adjustment on the name of the inner executor as I'm about to rename it.

deployment/helm_chart/opik/README.md Outdated Show resolved Hide resolved
deployment/helm_chart/opik/values.yaml Outdated Show resolved Hide resolved
@liyaka liyaka force-pushed the liya/DEV-2536-add-python-be-service branch from 136314f to c9669f4 Compare January 20, 2025 17:09
andrescrz
andrescrz approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@andrescrz andrescrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

obezpalko
obezpalko approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@obezpalko obezpalko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Nimrod007
Copy link
Collaborator

@liyaka this looks good!
@CRThaze - please review afterwards (non blocking) since this will have self hosted impact. thanks

@liyaka liyaka merged commit 7b59c2c into main Jan 21, 2025
2 checks passed
@liyaka liyaka deleted the liya/DEV-2536-add-python-be-service branch January 21, 2025 10:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@andrescrz andrescrz andrescrz approved these changes

@obezpalko obezpalko obezpalko approved these changes

@CRThaze CRThaze Awaiting requested review from CRThaze

@darenjacobs darenjacobs Awaiting requested review from darenjacobs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liyaka @Nimrod007 @andrescrz @obezpalko @CometActions