Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

OPIK-663: Pull instead of building Sandbox Python Executor image #1102

Merged

Conversation

andrescrz
Copy link
Collaborator

@andrescrz andrescrz commented Jan 21, 2025

Details

The Sandbox Python Executor image is now pulled instead of being built locally.

The exact registry, name and tag is parameterised as env variables and aligned with the variable names from the Helm charts.

The image is pulled before starting the service as a warm-up. Although this isn't strictly necessary as running a docker container automatically pulls the image if not available locally.

Other improvements in Dockerfile:

  • Added tini to handle zombie sub-processes.
  • Pulling minimum OS packages
  • Better wait on the docker daemon start up.
  • Etc.

Issues

OPIK-663

Testing

  • Run all automated tests.
  • Curl on Flask service locally.
  • Curl on gunicorn server inside Docker.

Documentation

@andrescrz andrescrz force-pushed the andrescrz/OPIK-663-move-python-executor-image-to-build-time branch from b720926 to e63e032 Compare January 21, 2025 17:52
@andrescrz andrescrz changed the title OPIK-663: Move Python executor image to build time OPIK-663: Pull instead of building Sandbox Python Executor image Jan 21, 2025
@andrescrz andrescrz marked this pull request as ready for review January 21, 2025 17:59
@andrescrz andrescrz requested a review from a team as a code owner January 21, 2025 17:59
@andrescrz andrescrz self-assigned this Jan 21, 2025
@andrescrz andrescrz added the enhancement New feature or request label Jan 21, 2025
@andrescrz andrescrz merged commit 40480d1 into main Jan 22, 2025
@andrescrz andrescrz deleted the andrescrz/OPIK-663-move-python-executor-image-to-build-time branch January 22, 2025 08:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants